diff options
author | Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> | 2010-06-30 16:02:02 +0800 |
---|---|---|
committer | Avi Kivity <avi@redhat.com> | 2010-08-01 10:47:22 +0300 |
commit | 36a2e6774bfb5f32a0f23bb155f1f960321f291b (patch) | |
tree | c367ac796b1e33694bcb3bd0e95cbd723667791b /arch/x86/kvm/paging_tmpl.h | |
parent | f5f48ee15c2ee3e44cf429e34b16c6fa9b900246 (diff) | |
download | op-kernel-dev-36a2e6774bfb5f32a0f23bb155f1f960321f291b.zip op-kernel-dev-36a2e6774bfb5f32a0f23bb155f1f960321f291b.tar.gz |
KVM: MMU: fix writable sync sp mapping
While we sync many unsync sp at one time(in mmu_sync_children()),
we may mapping the spte writable, it's dangerous, if one unsync
sp's mapping gfn is another unsync page's gfn.
For example:
SP1.pte[0] = P
SP2.gfn's pfn = P
[SP1.pte[0] = SP2.gfn's pfn]
First, we write protected SP1 and SP2, but SP1 and SP2 are still the
unsync sp.
Then, sync SP1 first, it will detect SP1.pte[0].gfn only has one unsync-sp,
that is SP2, so it will mapping it writable, but we plan to sync SP2 soon,
at this point, the SP2->unsync is not reliable since later we sync SP2 but
SP2->gfn is already writable.
So the final result is: SP2 is the sync page but SP2.gfn is writable.
This bug will corrupt guest's page table, fixed by mark read-only mapping
if the mapped gfn has shadow pages.
Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Diffstat (limited to 'arch/x86/kvm/paging_tmpl.h')
0 files changed, 0 insertions, 0 deletions