diff options
| author | Tejun Heo <tj@kernel.org> | 2009-04-01 15:06:33 +0900 |
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2009-04-02 06:08:05 +0200 |
| commit | eb12ce60c81826a99eadbc56401e08ceb37a0cc2 (patch) | |
| tree | 63a0451af66bb12b7f3e695fee1a9813addbeb9d /arch/x86/kernel/setup_percpu.c | |
| parent | 0f8f308925ebe0480bd9831d32963ee0b885e24b (diff) | |
| download | op-kernel-dev-eb12ce60c81826a99eadbc56401e08ceb37a0cc2.zip op-kernel-dev-eb12ce60c81826a99eadbc56401e08ceb37a0cc2.tar.gz | |
x86,percpu: fix inverted NUMA test in setup_pcpu_remap()
setup_percpu_remap() is for NUMA machines yet it bailed out with
-EINVAL if pcpu_need_numa(). Fix the inverted condition.
This problem was reported by David Miller and verified by Yinhai Lu.
Reported-by: David Miller <davem@davemloft.net>
Reported-by: Yinghai Lu <yinghai@kernel.org>
Signed-off-by: Tejun Heo <tj@kernel.org>
LKML-Reference: <49D30469.8020006@kernel.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/x86/kernel/setup_percpu.c')
| -rw-r--r-- | arch/x86/kernel/setup_percpu.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/kernel/setup_percpu.c b/arch/x86/kernel/setup_percpu.c index 400331b..876b127 100644 --- a/arch/x86/kernel/setup_percpu.c +++ b/arch/x86/kernel/setup_percpu.c @@ -162,7 +162,7 @@ static ssize_t __init setup_pcpu_remap(size_t static_size) * If large page isn't supported, there's no benefit in doing * this. Also, on non-NUMA, embedding is better. */ - if (!cpu_has_pse || pcpu_need_numa()) + if (!cpu_has_pse || !pcpu_need_numa()) return -EINVAL; last = NULL; |
