summaryrefslogtreecommitdiffstats
path: root/arch/x86/kernel/apic/apic_noop.c
diff options
context:
space:
mode:
authorAlexander Gordeev <agordeev@redhat.com>2012-06-07 15:15:44 +0200
committerIngo Molnar <mingo@kernel.org>2012-06-08 11:44:29 +0200
commit8637e38aff14d048b649075114023023a2e80fba (patch)
treecbafb89d56c83e7a74d2297a490989865e95cccd /arch/x86/kernel/apic/apic_noop.c
parent1bccd58bfffc5a677051937b332b71f0686187c1 (diff)
downloadop-kernel-dev-8637e38aff14d048b649075114023023a2e80fba.zip
op-kernel-dev-8637e38aff14d048b649075114023023a2e80fba.tar.gz
x86/apic: Avoid useless scanning thru a cpumask in assign_irq_vector()
In case of static vector allocation domains (i.e. flat) if all vector numbers are exhausted, an attempt to assign a new vector will lead to useless scans through all CPUs in the cpumask, even though it is known that each new pass would fail. Make this corner case less painful by letting report whether the vector allocation domain depends on passed arguments or not and stop scanning early. The same could have been achived by introducing a static flag to the apic operations. But let's allow vector_allocation_domain() have more intelligence here and decide dynamically, in case we would need it in the future. Signed-off-by: Alexander Gordeev <agordeev@redhat.com> Acked-by: Suresh Siddha <suresh.b.siddha@intel.com> Cc: Yinghai Lu <yinghai@kernel.org> Link: http://lkml.kernel.org/r/20120607131542.GE4759@dhcp-26-207.brq.redhat.com Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'arch/x86/kernel/apic/apic_noop.c')
-rw-r--r--arch/x86/kernel/apic/apic_noop.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/arch/x86/kernel/apic/apic_noop.c b/arch/x86/kernel/apic/apic_noop.c
index 3e43cf5..ac9edf2 100644
--- a/arch/x86/kernel/apic/apic_noop.c
+++ b/arch/x86/kernel/apic/apic_noop.c
@@ -100,11 +100,12 @@ static unsigned long noop_check_apicid_present(int bit)
return physid_isset(bit, phys_cpu_present_map);
}
-static void noop_vector_allocation_domain(int cpu, struct cpumask *retmask)
+static bool noop_vector_allocation_domain(int cpu, struct cpumask *retmask)
{
if (cpu != 0)
pr_warning("APIC: Vector allocated for non-BSP cpu\n");
cpumask_copy(retmask, cpumask_of(cpu));
+ return true;
}
static u32 noop_apic_read(u32 reg)
OpenPOWER on IntegriCloud