summaryrefslogtreecommitdiffstats
path: root/arch/x86/kernel/amd_iommu.c
diff options
context:
space:
mode:
authorChris Wright <chrisw@sous-sol.org>2010-04-02 18:27:53 -0700
committerJoerg Roedel <joerg.roedel@amd.com>2010-04-07 11:51:15 +0200
commit549c90dc9a6d659e792b2a42a0930c7da015ea4a (patch)
treee0d0115631aa40eb45b58fb24bdcd399d2e17e47 /arch/x86/kernel/amd_iommu.c
parent75f66533bc883f761a7adcab3281fe3323efbc90 (diff)
downloadop-kernel-dev-549c90dc9a6d659e792b2a42a0930c7da015ea4a.zip
op-kernel-dev-549c90dc9a6d659e792b2a42a0930c7da015ea4a.tar.gz
x86/amd-iommu: warn when issuing command to uninitialized cmd buffer
To catch future potential issues we can add a warning whenever we issue a command before the command buffer is fully initialized. Signed-off-by: Chris Wright <chrisw@sous-sol.org> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
Diffstat (limited to 'arch/x86/kernel/amd_iommu.c')
-rw-r--r--arch/x86/kernel/amd_iommu.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
index b06f29e..71dfc0a 100644
--- a/arch/x86/kernel/amd_iommu.c
+++ b/arch/x86/kernel/amd_iommu.c
@@ -392,6 +392,7 @@ static int __iommu_queue_command(struct amd_iommu *iommu, struct iommu_cmd *cmd)
u32 tail, head;
u8 *target;
+ WARN_ON(iommu->cmd_buf_size & CMD_BUFFER_UNINITIALIZED);
tail = readl(iommu->mmio_base + MMIO_CMD_TAIL_OFFSET);
target = iommu->cmd_buf + tail;
memcpy_toio(target, cmd, sizeof(*cmd));
OpenPOWER on IntegriCloud