summaryrefslogtreecommitdiffstats
path: root/arch/x86/kernel/.gitignore
diff options
context:
space:
mode:
authorSrivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>2014-03-11 02:07:57 +0530
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2014-03-20 13:43:43 +0100
commit8c60ea146499b9d2a81ceb5e3e0bd215ef0b6287 (patch)
tree1b1135663327d9910f0d83c738a8dc6f6805927a /arch/x86/kernel/.gitignore
parent047868ce2952bb6a86ccea3ecc6fd59faa9062a7 (diff)
downloadop-kernel-dev-8c60ea146499b9d2a81ceb5e3e0bd215ef0b6287.zip
op-kernel-dev-8c60ea146499b9d2a81ceb5e3e0bd215ef0b6287.tar.gz
x86, intel, cacheinfo: Fix CPU hotplug callback registration
Subsystems that want to register CPU hotplug callbacks, as well as perform initialization for the CPUs that are already online, often do it as shown below: get_online_cpus(); for_each_online_cpu(cpu) init_cpu(cpu); register_cpu_notifier(&foobar_cpu_notifier); put_online_cpus(); This is wrong, since it is prone to ABBA deadlocks involving the cpu_add_remove_lock and the cpu_hotplug.lock (when running concurrently with CPU hotplug operations). Instead, the correct and race-free way of performing the callback registration is: cpu_notifier_register_begin(); for_each_online_cpu(cpu) init_cpu(cpu); /* Note the use of the double underscored version of the API */ __register_cpu_notifier(&foobar_cpu_notifier); cpu_notifier_register_done(); Fix the intel cacheinfo code in x86 by using this latter form of callback registration. Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@kernel.org> Cc: "H. Peter Anvin" <hpa@zytor.com> Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'arch/x86/kernel/.gitignore')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud