diff options
| author | Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> | 2008-11-05 18:32:54 -0800 |
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2008-11-06 08:02:00 +0100 |
| commit | 99ea1b93bf80a287dd70499b96d9c4d06f320ff2 (patch) | |
| tree | 9ad4c59c9019050229223b08730394c8825ecca7 /arch/x86/ia32 | |
| parent | 4b33669e817a01dd99ff91df330d504ccfb2e99c (diff) | |
| download | op-kernel-dev-99ea1b93bf80a287dd70499b96d9c4d06f320ff2.zip op-kernel-dev-99ea1b93bf80a287dd70499b96d9c4d06f320ff2.tar.gz | |
x86: ia32_signal: do save_i387_xstate_ia32 at get_sigframe()
Impact: cleanup
move calling save_i387_xstate_ia32() into get_sigframe() from
setup_sigcontext().
Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/x86/ia32')
| -rw-r--r-- | arch/x86/ia32/ia32_signal.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/arch/x86/ia32/ia32_signal.c b/arch/x86/ia32/ia32_signal.c index 4bc02b2..47ddc23 100644 --- a/arch/x86/ia32/ia32_signal.c +++ b/arch/x86/ia32/ia32_signal.c @@ -367,12 +367,7 @@ static int ia32_setup_sigcontext(struct sigcontext_ia32 __user *sc, err |= __put_user(regs->flags, &sc->flags); err |= __put_user(regs->sp, &sc->sp_at_signal); - tmp = save_i387_xstate_ia32(fpstate); - if (tmp < 0) - err = -EFAULT; - else - err |= __put_user(ptr_to_compat(tmp ? fpstate : NULL), - &sc->fpstate); + err |= __put_user(ptr_to_compat(fpstate), &sc->fpstate); /* non-iBCS2 extensions.. */ err |= __put_user(mask, &sc->oldmask); @@ -408,6 +403,8 @@ static void __user *get_sigframe(struct k_sigaction *ka, struct pt_regs *regs, if (used_math()) { sp = sp - sig_xstate_ia32_size; *fpstate = (struct _fpstate_ia32 *) sp; + if (save_i387_xstate_ia32(*fpstate) < 0) + return (void __user *) -1L; } sp -= frame_size; |
