summaryrefslogtreecommitdiffstats
path: root/arch/x86/crypto/sha-mb
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2014-11-22 21:36:28 +0300
committerHerbert Xu <herbert@gondor.apana.org.au>2014-11-25 22:50:43 +0800
commit5d1b3c98ec2015036349c57289711f26c2d5fe01 (patch)
treef478eb063f2b7e7a1baea4a7ccdef3754afc9be7 /arch/x86/crypto/sha-mb
parentb1c9952afeae3e7da798ca08cab0e97caaba0706 (diff)
downloadop-kernel-dev-5d1b3c98ec2015036349c57289711f26c2d5fe01.zip
op-kernel-dev-5d1b3c98ec2015036349c57289711f26c2d5fe01.tar.gz
crypto: sha-mb - remove a bogus NULL check
This can't be NULL and we dereferenced it earlier. Smatch used to ignore these things where the pointer was obviously non-NULL but I've found that sometimes the intention was to check something else so we were maybe missing bugs. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Tim Chen <tim.c.chen@linux.intel.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'arch/x86/crypto/sha-mb')
-rw-r--r--arch/x86/crypto/sha-mb/sha1_mb.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/arch/x86/crypto/sha-mb/sha1_mb.c b/arch/x86/crypto/sha-mb/sha1_mb.c
index 99eefd8..a225a5ca 100644
--- a/arch/x86/crypto/sha-mb/sha1_mb.c
+++ b/arch/x86/crypto/sha-mb/sha1_mb.c
@@ -204,8 +204,7 @@ static struct sha1_hash_ctx *sha1_ctx_mgr_resubmit(struct sha1_ctx_mgr *mgr, str
continue;
}
- if (ctx)
- ctx->status = HASH_CTX_STS_IDLE;
+ ctx->status = HASH_CTX_STS_IDLE;
return ctx;
}
OpenPOWER on IntegriCloud