diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2016-07-15 14:05:33 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-07-27 22:53:17 -0700 |
| commit | fa1608285b0c350af4848b32e42261f02806073e (patch) | |
| tree | b9bdbd5aa0108215ec593fa23e1b060b024b4d58 /arch/sparc | |
| parent | 4f6deb8cbab532a8d7250bc09234c1795ecb5e2c (diff) | |
| download | op-kernel-dev-fa1608285b0c350af4848b32e42261f02806073e.zip op-kernel-dev-fa1608285b0c350af4848b32e42261f02806073e.tar.gz | |
sparc32: off by ones in BUG_ON()
Smatch complains that these tests are off by one, which is true but not
life threatening.
arch/sparc/kernel/irq_32.c:169 irq_link()
error: buffer overflow 'irq_map' 384 <= 384
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'arch/sparc')
| -rw-r--r-- | arch/sparc/kernel/irq_32.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/sparc/kernel/irq_32.c b/arch/sparc/kernel/irq_32.c index a979e99..cac4a55 100644 --- a/arch/sparc/kernel/irq_32.c +++ b/arch/sparc/kernel/irq_32.c @@ -165,7 +165,7 @@ void irq_link(unsigned int irq) p = &irq_table[irq]; pil = p->pil; - BUG_ON(pil > SUN4D_MAX_IRQ); + BUG_ON(pil >= SUN4D_MAX_IRQ); p->next = irq_map[pil]; irq_map[pil] = p; @@ -182,7 +182,7 @@ void irq_unlink(unsigned int irq) spin_lock_irqsave(&irq_map_lock, flags); p = &irq_table[irq]; - BUG_ON(p->pil > SUN4D_MAX_IRQ); + BUG_ON(p->pil >= SUN4D_MAX_IRQ); pnext = &irq_map[p->pil]; while (*pnext != p) pnext = &(*pnext)->next; |
