diff options
author | Nicolas Pitre <nico@fluxnic.net> | 2010-09-20 04:10:43 +0100 |
---|---|---|
committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2010-09-23 15:17:04 +0100 |
commit | 2f27bf834e1d0a06e83d7458b535891c552271aa (patch) | |
tree | 6d0ed3804614f146a8001245d52579c4ee0cb311 /arch/sh | |
parent | 1d5b4c0fa9ff79a4f01e5efc1caefd16b190a3dc (diff) | |
download | op-kernel-dev-2f27bf834e1d0a06e83d7458b535891c552271aa.zip op-kernel-dev-2f27bf834e1d0a06e83d7458b535891c552271aa.tar.gz |
ARM: 6401/1: plug a race in the alignment trap handler
When the policy for user space is to ignore misaligned accesses from user
space, the processor then performs a documented rotation on the accessed
data. This is the result of the access being trapped, and the kernel
disabling the alignment trap before returning to user space again.
In kernel space we always want misaligned accesses to be fixed up. This
is enforced by always re-enabling the alignment trap on every entry into
kernel space from user space. No such re-enabling is performed when an
exception occurs while already in kernel space as the alignment trap is
always supposed to be enabled in that case.
There is however a small race window when a misaligned access in user
space is trapped and the alignment trap disabled, but the CPU didn't
return to user space just yet. Any exception would be entered from kernel
space at that point and the kernel would then execute with the alignment
trap disabled.
Thanks to Maxime Bizon <mbizon@freebox.fr> for providing a test module
that made this issue reproducible.
Signed-off-by: Nicolas Pitre <nicolas.pitre@linaro.org>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'arch/sh')
0 files changed, 0 insertions, 0 deletions