diff options
| author | Michael Holzheu <holzheu@linux.vnet.ibm.com> | 2015-01-08 14:36:21 +0100 |
|---|---|---|
| committer | Martin Schwidefsky <schwidefsky@de.ibm.com> | 2015-01-09 10:10:30 +0100 |
| commit | df3eed3d282f2fe1ffb73d3545fcde4e9b80a0d3 (patch) | |
| tree | 26b328857f004c83f45eb3a5af446ead0dbc973c /arch/s390/net | |
| parent | fbc89c952f004fb9191c23605a1428df6dd39a90 (diff) | |
| download | op-kernel-dev-df3eed3d282f2fe1ffb73d3545fcde4e9b80a0d3.zip op-kernel-dev-df3eed3d282f2fe1ffb73d3545fcde4e9b80a0d3.tar.gz | |
s390/bpf: Fix ALU_NEG (A = -A)
Currently the LOAD NEGATIVE (lnr) instruction is used for ALU_NEG. This
instruction always loads the negative value. Therefore, if A is already
negative, it remains unchanged. To fix this use LOAD COMPLEMENT (lcr)
instead.
Signed-off-by: Michael Holzheu <holzheu@linux.vnet.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Diffstat (limited to 'arch/s390/net')
| -rw-r--r-- | arch/s390/net/bpf_jit_comp.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/s390/net/bpf_jit_comp.c b/arch/s390/net/bpf_jit_comp.c index c52ac77..8bc474f 100644 --- a/arch/s390/net/bpf_jit_comp.c +++ b/arch/s390/net/bpf_jit_comp.c @@ -431,8 +431,8 @@ static int bpf_jit_insn(struct bpf_jit *jit, struct sock_filter *filter, EMIT4_DISP(0x88500000, K); break; case BPF_ALU | BPF_NEG: /* A = -A */ - /* lnr %r5,%r5 */ - EMIT2(0x1155); + /* lcr %r5,%r5 */ + EMIT2(0x1355); break; case BPF_JMP | BPF_JA: /* ip += K */ offset = addrs[i + K] + jit->start - jit->prg; |
