summaryrefslogtreecommitdiffstats
path: root/arch/s390/lib
diff options
context:
space:
mode:
authorHeiko Carstens <heiko.carstens@de.ibm.com>2013-09-23 12:01:44 +0200
committerMartin Schwidefsky <schwidefsky@de.ibm.com>2013-10-24 17:16:56 +0200
commit7d7c7b24e416afb2637be8447e03ca4457c100fd (patch)
tree3f6df4a49ba2fdaaa01e824d77811777d745cc6d /arch/s390/lib
parentb1cb7e2b6c3e8758e7406422b66c54c066737977 (diff)
downloadop-kernel-dev-7d7c7b24e416afb2637be8447e03ca4457c100fd.zip
op-kernel-dev-7d7c7b24e416afb2637be8447e03ca4457c100fd.tar.gz
s390/bitops: rename find_first_bit_left() to find_first_bit_inv()
find_first_bit_left() and friends have nothing to do with the normal LSB0 bit numbering for big endian machines used in Linux (least significant bit has bit number 0). Instead they use MSB0 bit numbering, where the most signficant bit has bit number 0. So rename find_first_bit_left() and friends to find_first_bit_inv(), to avoid any confusion. Also provide inv versions of set_bit, clear_bit and test_bit. This also removes the confusing use of e.g. set_bit() in airq.c which uses a "be_to_le" bit number conversion, which could imply that instead set_bit_le() could be used. But that is entirely wrong since the _le bitops variant uses yet another bit numbering scheme. Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Diffstat (limited to 'arch/s390/lib')
-rw-r--r--arch/s390/lib/find.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/arch/s390/lib/find.c b/arch/s390/lib/find.c
index 8963929..620d34d 100644
--- a/arch/s390/lib/find.c
+++ b/arch/s390/lib/find.c
@@ -15,7 +15,7 @@
#include <linux/bitops.h>
#include <linux/export.h>
-unsigned long find_first_bit_left(const unsigned long *addr, unsigned long size)
+unsigned long find_first_bit_inv(const unsigned long *addr, unsigned long size)
{
const unsigned long *p = addr;
unsigned long result = 0;
@@ -35,10 +35,10 @@ unsigned long find_first_bit_left(const unsigned long *addr, unsigned long size)
found:
return result + (__fls(tmp) ^ (BITS_PER_LONG - 1));
}
-EXPORT_SYMBOL(find_first_bit_left);
+EXPORT_SYMBOL(find_first_bit_inv);
-unsigned long find_next_bit_left(const unsigned long *addr, unsigned long size,
- unsigned long offset)
+unsigned long find_next_bit_inv(const unsigned long *addr, unsigned long size,
+ unsigned long offset)
{
const unsigned long *p = addr + (offset / BITS_PER_LONG);
unsigned long result = offset & ~(BITS_PER_LONG - 1);
@@ -74,4 +74,4 @@ found_first:
found_middle:
return result + (__fls(tmp) ^ (BITS_PER_LONG - 1));
}
-EXPORT_SYMBOL(find_next_bit_left);
+EXPORT_SYMBOL(find_next_bit_inv);
OpenPOWER on IntegriCloud