summaryrefslogtreecommitdiffstats
path: root/arch/powerpc/sysdev
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2011-08-08 13:18:02 +0200
committerKumar Gala <galak@kernel.crashing.org>2011-11-24 02:01:24 -0600
commite3854b6e25d1b092c30c5f81a04fe6fc839b1e26 (patch)
treefa286f9ef6ff12713dfb958b10a094bc69fb9504 /arch/powerpc/sysdev
parent7145cf12095265b8a292835d0f6da87f89fac1d1 (diff)
downloadop-kernel-dev-e3854b6e25d1b092c30c5f81a04fe6fc839b1e26.zip
op-kernel-dev-e3854b6e25d1b092c30c5f81a04fe6fc839b1e26.tar.gz
arch/powerpc/sysdev/ehv_pic.c: add missing kfree
At this point, ehv_pic has been allocated but not stored anywhere, so it should be freed before leaving the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @exists@ local idexpression x; statement S,S1; expression E; identifier fl; expression *ptr != NULL; @@ x = \(kmalloc\|kzalloc\|kcalloc\)(...); ... if (x == NULL) S <... when != x when != if (...) { <+...kfree(x)...+> } when any when != true x == NULL x->fl ...> ( if (x == NULL) S1 | if (...) { ... when != x when forall ( return \(0\|<+...x...+>\|ptr\); | * return ...; ) } ) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Acked-by: Timur Tabi <timur@freescale.com> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
Diffstat (limited to 'arch/powerpc/sysdev')
-rw-r--r--arch/powerpc/sysdev/ehv_pic.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/powerpc/sysdev/ehv_pic.c b/arch/powerpc/sysdev/ehv_pic.c
index af1a5df..b6731e4 100644
--- a/arch/powerpc/sysdev/ehv_pic.c
+++ b/arch/powerpc/sysdev/ehv_pic.c
@@ -280,6 +280,7 @@ void __init ehv_pic_init(void)
if (!ehv_pic->irqhost) {
of_node_put(np);
+ kfree(ehv_pic);
return;
}
OpenPOWER on IntegriCloud