diff options
| author | Julia Lawall <julia@diku.dk> | 2011-12-23 18:39:33 +0100 |
|---|---|---|
| committer | Kumar Gala <galak@kernel.crashing.org> | 2012-01-04 15:43:03 -0600 |
| commit | c6ca52ad32cb9a4b9b331a60966ffa4d00ce3f37 (patch) | |
| tree | 0f314d01cf3bc6466cb4f9ea6d98413ecc5e6dae /arch/powerpc/sysdev/fsl_rmu.c | |
| parent | a20cbdeffce247a2b6fb83cd8d22433994068565 (diff) | |
| download | op-kernel-dev-c6ca52ad32cb9a4b9b331a60966ffa4d00ce3f37.zip op-kernel-dev-c6ca52ad32cb9a4b9b331a60966ffa4d00ce3f37.tar.gz | |
arch/powerpc/sysdev/fsl_rmu.c: introduce missing kfree
rmu needs to be freed before leaving the function in an error case.
A simplified version of the semantic match that finds the problem is as
follows: (http://coccinelle.lip6.fr)
// <smpl>
@r exists@
local idexpression x;
statement S;
identifier f1;
position p1,p2;
expression *ptr != NULL;
@@
x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
when != if (...) { <+...x...+> }
x->f1
...>
(
return \(0\|<+...x...+>\|ptr\);
|
return@p2 ...;
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
Diffstat (limited to 'arch/powerpc/sysdev/fsl_rmu.c')
| -rw-r--r-- | arch/powerpc/sysdev/fsl_rmu.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/powerpc/sysdev/fsl_rmu.c b/arch/powerpc/sysdev/fsl_rmu.c index 02445a5..1548578 100644 --- a/arch/powerpc/sysdev/fsl_rmu.c +++ b/arch/powerpc/sysdev/fsl_rmu.c @@ -1081,6 +1081,7 @@ int fsl_rio_setup_rmu(struct rio_mport *mport, struct device_node *node) if (!msg_addr) { pr_err("%s: unable to find 'reg' property of message-unit\n", node->full_name); + kfree(rmu); return -ENOMEM; } msg_start = of_read_number(msg_addr, aw); |
