summaryrefslogtreecommitdiffstats
path: root/arch/powerpc/kernel
diff options
context:
space:
mode:
authorDaniel Axtens <dja@axtens.net>2015-03-31 16:00:41 +1100
committerMichael Ellerman <mpe@ellerman.id.au>2015-04-11 20:49:10 +1000
commitc88c2a188905cb3077c3c38dc498e7e9f8eebeee (patch)
tree36fd0a09d7edba5db25562836d3228c6a823fd5f /arch/powerpc/kernel
parentba9c8f227358bcbc80fca19e7a339883cbc956a5 (diff)
downloadop-kernel-dev-c88c2a188905cb3077c3c38dc498e7e9f8eebeee.zip
op-kernel-dev-c88c2a188905cb3077c3c38dc498e7e9f8eebeee.tar.gz
powerpc: pcibios_enable_device_hook: return bool rather than int
pcibios_enable_device_hook returned an int. Every implementation returned either -EINVAL or 0. The return value wasn't propagated by the caller: any non-zero return value caused pcibios_enable_device to return -EINVAL itself. Therefore, make the hook return a bool. Signed-off-by: Daniel Axtens <dja@axtens.net> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Diffstat (limited to 'arch/powerpc/kernel')
-rw-r--r--arch/powerpc/kernel/pci-common.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c
index bcf618b..17827c7 100644
--- a/arch/powerpc/kernel/pci-common.c
+++ b/arch/powerpc/kernel/pci-common.c
@@ -1451,7 +1451,7 @@ EXPORT_SYMBOL_GPL(pcibios_finish_adding_to_bus);
int pcibios_enable_device(struct pci_dev *dev, int mask)
{
if (ppc_md.pcibios_enable_device_hook)
- if (ppc_md.pcibios_enable_device_hook(dev))
+ if (!ppc_md.pcibios_enable_device_hook(dev))
return -EINVAL;
return pci_enable_resources(dev, mask);
OpenPOWER on IntegriCloud