diff options
author | Henrik Austad <haustad@cisco.com> | 2013-03-26 08:16:42 +0100 |
---|---|---|
committer | Chris Metcalf <cmetcalf@tilera.com> | 2013-03-26 13:52:16 -0400 |
commit | 39e8202bb3b83a826e5825b1a07bbbf30ae9a140 (patch) | |
tree | a4c2a4fd3198fd326836d61db3f39a49f5b722de /arch/mn10300/mm | |
parent | d9acae6baf41c0561f8c532b20cfd955fd1edc2d (diff) | |
download | op-kernel-dev-39e8202bb3b83a826e5825b1a07bbbf30ae9a140.zip op-kernel-dev-39e8202bb3b83a826e5825b1a07bbbf30ae9a140.tar.gz |
tile: ns2cycles should use __raw_get_cpu_var
ns2cycles use per_cpu variables, and will, eventually, find its way into
smp_processor_id(). This is not safe in a preemptible kernel;
preemption should ideally be disabled.
BUG: using smp_processor_id() in preemptible [00000000] code:
systemd-modules/367
caller is ns2cycles+0x40/0xb8
Starting stack dump of tid 367, pid 367 (systemd-modules) on cpu 2 at
cycle 20969956421
frame 0: 0xfffffff70004b860 dump_stack+0x0/0x20 (sp 0xfffffe407993fa90)
frame 1: 0xfffffff7006abc28 debug_smp_processor_id+0x1a8/0x1e0 (sp
0xfffffe407993fa90)
frame 2: 0xfffffff7004d7b40 ns2cycles+0x40/0xb8 (sp 0xfffffe407993fab8)
frame 3: 0xfffffff7004dc578 __ndelay+0x38/0x80 (sp 0xfffffe407993fae0)
However, in this case:
- the frequency is the same accross all cores
- we use the data read-only
- we do not scale the frequency
Which means that we can use the __raw_get_cpu_var instead.
Signed-off-by: Henrik Austad <haustad@cisco.com>
Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
Diffstat (limited to 'arch/mn10300/mm')
0 files changed, 0 insertions, 0 deletions