summaryrefslogtreecommitdiffstats
path: root/arch/mips/include/asm/irq.h
diff options
context:
space:
mode:
authorBjorn Helgaas <bhelgaas@google.com>2015-07-12 18:11:46 -0500
committerRalf Baechle <ralf@linux-mips.org>2015-09-03 12:07:38 +0200
commit770847bad0200b62af2d93808b4e69d82f14264e (patch)
treecfbcb7a0de0219f36bf8944df4562f2355833774 /arch/mips/include/asm/irq.h
parentec0b9d35d1fbf7e3a3eccc662ad641794d3685a5 (diff)
downloadop-kernel-dev-770847bad0200b62af2d93808b4e69d82f14264e.zip
op-kernel-dev-770847bad0200b62af2d93808b4e69d82f14264e.tar.gz
MIPS: Remove "weak" from get_c0_fdc_int() declaration
Weak header file declarations are error-prone because they make every definition weak, and the linker chooses one based on link order (see 10629d711ed7 ("PCI: Remove __weak annotation from pcibios_get_phb_of_node decl")). The most elegant solution is to have a weak default implementation and allow a strong function to override it. Then we don't have to test whether a definition is present, and if there are ever multiple strong definitions, we get a link error instead of calling a random definition. Add a weak get_c0_fdc_int() definition with the default code and remove the weak annotation from the declaration. Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: James Hogan <james.hogan@imgtec.com> Cc: Andrew Bresticker <abrestic@chromium.org> Cc: linux-mips@linux-mips.org Cc: linux-kernel@vger.kernel.org Patchwork: https://patchwork.linux-mips.org/patch/10687/ Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Diffstat (limited to 'arch/mips/include/asm/irq.h')
-rw-r--r--arch/mips/include/asm/irq.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/mips/include/asm/irq.h b/arch/mips/include/asm/irq.h
index f0db99f..15e0fec 100644
--- a/arch/mips/include/asm/irq.h
+++ b/arch/mips/include/asm/irq.h
@@ -49,7 +49,7 @@ extern int cp0_compare_irq_shift;
extern int cp0_perfcount_irq;
extern int cp0_fdc_irq;
-extern int __weak get_c0_fdc_int(void);
+extern int get_c0_fdc_int(void);
void arch_trigger_all_cpu_backtrace(bool);
#define arch_trigger_all_cpu_backtrace arch_trigger_all_cpu_backtrace
OpenPOWER on IntegriCloud