summaryrefslogtreecommitdiffstats
path: root/arch/ia64
diff options
context:
space:
mode:
authorJack Steiner <steiner@sgi.com>2005-12-22 13:45:41 -0600
committerTony Luck <tony.luck@intel.com>2006-01-13 14:10:06 -0800
commitcfbb1426bd76c4ba6ec4491c8df2a5dd3d984750 (patch)
tree4fe639274b651ea77c9130eae0ccca36e16d6d17 /arch/ia64
parent17e8ce0e9417eee1f57f9b3d4aad168425e043c3 (diff)
downloadop-kernel-dev-cfbb1426bd76c4ba6ec4491c8df2a5dd3d984750.zip
op-kernel-dev-cfbb1426bd76c4ba6ec4491c8df2a5dd3d984750.tar.gz
[IA64] Hole in IA64 TLB flushing from system threads
I originally thought this was an bug only in the SN code, but I think I also see a hole in the generic IA64 tlb code. (Separate patch was sent for the SN problem). It looks like there is a bug in the TLB flushing code. During context switch, kernel threads (kswapd, for example) inherit the mm of the task that was previously running on the cpu. Normally, this is ok because the previous context is still loaded into the RR registers. However, if the owner of the mm migrates to another cpu, changes it's context number, and references a page before kswapd issues a tlb_purge for that same page, the purge will be done with a stale context number (& RR registers). Signed-off-by: Tony Luck <tony.luck@intel.com>
Diffstat (limited to 'arch/ia64')
-rw-r--r--arch/ia64/mm/tlb.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/ia64/mm/tlb.c b/arch/ia64/mm/tlb.c
index 41105d4..6a4eec9 100644
--- a/arch/ia64/mm/tlb.c
+++ b/arch/ia64/mm/tlb.c
@@ -90,7 +90,7 @@ ia64_global_tlb_purge (struct mm_struct *mm, unsigned long start,
{
static DEFINE_SPINLOCK(ptcg_lock);
- if (mm != current->active_mm) {
+ if (mm != current->active_mm || !current->mm) {
flush_tlb_all();
return;
}
OpenPOWER on IntegriCloud