summaryrefslogtreecommitdiffstats
path: root/arch/avr32
diff options
context:
space:
mode:
authorManfred Spraul <manfred@colorfullife.com>2008-08-20 15:39:59 +0200
committerHaavard Skinnemoen <haavard.skinnemoen@atmel.com>2008-09-19 20:08:08 +0200
commit3d431a742728e6b619ce57a030a92d228c13d1d2 (patch)
tree10fe28291350b2b4ce9492856ab223d58a341b6d /arch/avr32
parent73d4393d1df4ff3892b040396f101ede94e9e846 (diff)
downloadop-kernel-dev-3d431a742728e6b619ce57a030a92d228c13d1d2.zip
op-kernel-dev-3d431a742728e6b619ce57a030a92d228c13d1d2.tar.gz
avr32: nmi_enter() without nmi_exit()
While updating the rcu code, I noticed that do_nmi() for AVR32 is odd: There is an nmi_enter() call without an nmi_exit(). This can't be correct, it breaks rcu (at least the preempt version) and lockdep. [haavard.skinnemoen@atmel.com: fixed another case that returned directly] Signed-off-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Diffstat (limited to 'arch/avr32')
-rw-r--r--arch/avr32/kernel/traps.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/arch/avr32/kernel/traps.c b/arch/avr32/kernel/traps.c
index b835c4c..0d98737 100644
--- a/arch/avr32/kernel/traps.c
+++ b/arch/avr32/kernel/traps.c
@@ -116,15 +116,15 @@ asmlinkage void do_nmi(unsigned long ecr, struct pt_regs *regs)
switch (ret) {
case NOTIFY_OK:
case NOTIFY_STOP:
- return;
+ break;
case NOTIFY_BAD:
die("Fatal Non-Maskable Interrupt", regs, SIGINT);
default:
+ printk(KERN_ALERT "Got NMI, but nobody cared. Disabling...\n");
+ nmi_disable();
break;
}
-
- printk(KERN_ALERT "Got NMI, but nobody cared. Disabling...\n");
- nmi_disable();
+ nmi_exit();
}
asmlinkage void do_critical_exception(unsigned long ecr, struct pt_regs *regs)
OpenPOWER on IntegriCloud