summaryrefslogtreecommitdiffstats
path: root/arch/arm
diff options
context:
space:
mode:
authorSamuel <sameo@openedhand.com>2007-08-28 19:56:34 +0100
committerRussell King <rmk+kernel@arm.linux.org.uk>2007-08-28 22:59:43 +0100
commitfd51bcc5dc4073b18308f25846aa3b421fa3c42e (patch)
tree43e70f2fddb67614a659086cfb3e83d4cd3dfef8 /arch/arm
parentd555dd5065ab6dd4437c609950c5d9c6377b4896 (diff)
downloadop-kernel-dev-fd51bcc5dc4073b18308f25846aa3b421fa3c42e.zip
op-kernel-dev-fd51bcc5dc4073b18308f25846aa3b421fa3c42e.tar.gz
[ARM] 4557/1: Fix PXA irq gpio initialization
As pointed out by Jrgen, we are overflowing the number of GPIOs in pxa_init_irq_gpio(). I'm seeing the same problem on my HTC Universal PXA270 based PDA. According to Eric, the function argument is the number of GPIOs, so we should keep the semantics and reduce the number of iteration by 1. Signed-off-by: Samuel Ortiz <sameo@openedhand.com> Acked-by: Jrgen Schindele <linux@schindele.name> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'arch/arm')
-rw-r--r--arch/arm/mach-pxa/irq.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/arm/mach-pxa/irq.c b/arch/arm/mach-pxa/irq.c
index 4b867b0..ae2ae08 100644
--- a/arch/arm/mach-pxa/irq.c
+++ b/arch/arm/mach-pxa/irq.c
@@ -365,7 +365,7 @@ void __init pxa_init_irq_gpio(int gpio_nr)
set_irq_flags(irq, IRQF_VALID | IRQF_PROBE);
}
- for (irq = IRQ_GPIO(2); irq <= IRQ_GPIO(gpio_nr); irq++) {
+ for (irq = IRQ_GPIO(2); irq < IRQ_GPIO(gpio_nr); irq++) {
set_irq_chip(irq, &pxa_muxed_gpio_chip);
set_irq_handler(irq, handle_edge_irq);
set_irq_flags(irq, IRQF_VALID | IRQF_PROBE);
OpenPOWER on IntegriCloud