summaryrefslogtreecommitdiffstats
path: root/Kbuild
diff options
context:
space:
mode:
authorJohan Hovold <johan@kernel.org>2015-05-04 17:10:28 +0200
committerLinus Walleij <linus.walleij@linaro.org>2015-05-12 10:46:31 +0200
commit52176d0d3be29ccb01a44ee77532bb3969939ecf (patch)
treec9ba29e8f5031f40a50254b012a9c176c6d71a2b /Kbuild
parentfab28b89a1c418382638d3837739faad9111fa8e (diff)
downloadop-kernel-dev-52176d0d3be29ccb01a44ee77532bb3969939ecf.zip
op-kernel-dev-52176d0d3be29ccb01a44ee77532bb3969939ecf.tar.gz
gpio: sysfs: fix redundant lock-as-irq handling
Drivers should call gpiochip_lock_as_irq (which prevents the pin direction from being changed) in their irq_request_resources callbacks but some drivers currently fail to do so. Instead a second, explicit and often redundant call to lock-as-irq is made by the sysfs-interface implementation after an irq has been requested. Move the explicit call before the irq-request to match the unlock done after the irq is later released. Note that this also fixes an irq leak, should the explicit call ever have failed. Also add a comment about removing the redundant call once the broken drivers have been fixed. Signed-off-by: Johan Hovold <johan@kernel.org> Reviewed-by: Alexandre Courbot <acourbot@nvidia.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'Kbuild')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud