summaryrefslogtreecommitdiffstats
path: root/Documentation
diff options
context:
space:
mode:
authorRusty Russell <rusty@rustcorp.com.au>2009-06-12 22:27:11 -0600
committerRusty Russell <rusty@rustcorp.com.au>2009-06-12 22:27:12 +0930
commit95c517c09bad31a03e22f2fdb5f0aa26a490a92d (patch)
treeaa34fdb7ca3a6b7575a2ac7639c157995d334bc3 /Documentation
parent38bc2b8c56a2e212bbd19de7cf9976dcc7bf9953 (diff)
downloadop-kernel-dev-95c517c09bad31a03e22f2fdb5f0aa26a490a92d.zip
op-kernel-dev-95c517c09bad31a03e22f2fdb5f0aa26a490a92d.tar.gz
lguest: avoid sending interrupts to Guest when no activity occurs.
If we track how many buffers we've used, we can tell whether we really need to interrupt the Guest. This happens as a side effect of spurious notifications. Spurious notifications happen because it can take a while before the Host thread wakes up and sets the VRING_USED_F_NO_NOTIFY flag, and meanwhile the Guest can more notifications. A real fix would be to use wake counts, rather than a suppression flag, but the practical difference is generally in the noise: the interrupt is usually coalesced into a pending one anyway so we just save a system call which isn't clearly measurable. Secs Spurious IRQS 1G TCP Guest->Host: 3.93 58 1M normal pings: 100 72 1M 1k pings (-l 120): 57 492904 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to 'Documentation')
-rw-r--r--Documentation/lguest/lguest.c9
1 files changed, 9 insertions, 0 deletions
diff --git a/Documentation/lguest/lguest.c b/Documentation/lguest/lguest.c
index 84c471b..20f8253 100644
--- a/Documentation/lguest/lguest.c
+++ b/Documentation/lguest/lguest.c
@@ -151,6 +151,9 @@ struct virtqueue
/* Last available index we saw. */
u16 last_avail_idx;
+ /* How many are used since we sent last irq? */
+ unsigned int pending_used;
+
/* Eventfd where Guest notifications arrive. */
int eventfd;
@@ -556,6 +559,11 @@ static void trigger_irq(struct virtqueue *vq)
{
unsigned long buf[] = { LHREQ_IRQ, vq->config.irq };
+ /* Don't inform them if nothing used. */
+ if (!vq->pending_used)
+ return;
+ vq->pending_used = 0;
+
/* If they don't want an interrupt, don't send one, unless empty. */
if ((vq->vring.avail->flags & VRING_AVAIL_F_NO_INTERRUPT)
&& lg_last_avail(vq) != vq->vring.avail->idx)
@@ -647,6 +655,7 @@ static void add_used(struct virtqueue *vq, unsigned int head, int len)
/* Make sure buffer is written before we update index. */
wmb();
vq->vring.used->idx++;
+ vq->pending_used++;
}
/* And here's the combo meal deal. Supersize me! */
OpenPOWER on IntegriCloud