diff options
author | dingtianhong <dingtianhong@huawei.com> | 2013-11-22 22:28:43 +0800 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-11-28 18:20:18 -0500 |
commit | fe9d04afe9bee0ec37a9724937443b2c0e39ce4b (patch) | |
tree | 67279311408105591589999782d18d7bffc05209 /CREDITS | |
parent | 31e20bad8d5871c6f8673c28ea26ab7a0e520086 (diff) | |
download | op-kernel-dev-fe9d04afe9bee0ec37a9724937443b2c0e39ce4b.zip op-kernel-dev-fe9d04afe9bee0ec37a9724937443b2c0e39ce4b.tar.gz |
bonding: disable arp and enable mii monitoring when bond change to no uses arp mode
Because the ARP monitoring is not support for 802.3ad, but I still
could change the mode to 802.3ad from ab mode while ARP monitoring
is running, it is incorrect.
So add a check for 802.3ad in bonding_store_mode to fix the problem,
and make a new macro BOND_NO_USES_ARP() to simplify the code.
v2: according to the Dan Williams's suggestion, bond mode is the most
important bond option, it should override any of the other sub-options.
So when the mode is changed, the conficting values should be cleared
or reset, otherwise the user has to duplicate more operations to modify
the logic. I disable the arp and enable mii monitoring when the bond mode
is changed to AB, TB and 8023AD if the arp interval is true.
v3: according to the Nik's suggestion, the default value of miimon should need
a name, there is several place to use it, and the bond_store_arp_interval()
could use micro BOND_NO_USES_ARP to make the code more simpify.
Suggested-by: Dan Williams <dcbw@redhat.com>
Suggested-by: Nikolay Aleksandrov <nikolay@redhat.com>
Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
Reviewed-by: Nikolay Aleksandrov <nikolay@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'CREDITS')
0 files changed, 0 insertions, 0 deletions