summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAxel Lin <axel.lin@ingics.com>2014-08-06 08:24:00 +0800
committerGuenter Roeck <linux@roeck-us.net>2014-08-05 19:44:42 -0700
commitfa642d9d6e502fbdbd1122a6a247c8ad17063a29 (patch)
treebd56997463057d2127fdd6777d70ecf65e668c38
parentdb59ac434230c2d6c051bb314f320ad977e6841d (diff)
downloadop-kernel-dev-fa642d9d6e502fbdbd1122a6a247c8ad17063a29.zip
op-kernel-dev-fa642d9d6e502fbdbd1122a6a247c8ad17063a29.tar.gz
hwmon: (lm87) Fix vrm write operation
vrm is an u8, so the written value needs to be limited to [0, 255]. Signed-off-by: Axel Lin <axel.lin@ingics.com> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
-rw-r--r--drivers/hwmon/lm87.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/hwmon/lm87.c b/drivers/hwmon/lm87.c
index ba1d83d..a5e2958 100644
--- a/drivers/hwmon/lm87.c
+++ b/drivers/hwmon/lm87.c
@@ -617,6 +617,10 @@ static ssize_t set_vrm(struct device *dev, struct device_attribute *attr,
err = kstrtoul(buf, 10, &val);
if (err)
return err;
+
+ if (val > 255)
+ return -EINVAL;
+
data->vrm = val;
return count;
}
OpenPOWER on IntegriCloud