diff options
| author | Kees Cook <keescook@chromium.org> | 2017-10-17 19:04:43 -0700 |
|---|---|---|
| committer | Jessica Yu <jeyu@kernel.org> | 2017-10-31 15:30:47 +0100 |
| commit | ece1996a21eeb344b49200e627c6660111009c10 (patch) | |
| tree | e3a5f6bebaf15351ef42e30926d5f6aeb7f4a0c1 | |
| parent | e4dca7b7aa08b22893c45485d222b5807c1375ae (diff) | |
| download | op-kernel-dev-ece1996a21eeb344b49200e627c6660111009c10.zip op-kernel-dev-ece1996a21eeb344b49200e627c6660111009c10.tar.gz | |
module: Do not paper over type mismatches in module_param_call()
The module_param_call() macro was explicitly casting the .set and
.get function prototypes away. This can lead to hard-to-find type
mismatches. Now that all the function prototypes have been fixed
tree-wide, we can drop these casts, and use named initializers too.
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Jessica Yu <jeyu@kernel.org>
| -rw-r--r-- | include/linux/moduleparam.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h index 037a90a..2038625 100644 --- a/include/linux/moduleparam.h +++ b/include/linux/moduleparam.h @@ -227,9 +227,9 @@ struct kparam_array VERIFY_OCTAL_PERMISSIONS(perm), level, flags, { arg } } /* Obsolete - use module_param_cb() */ -#define module_param_call(name, set, get, arg, perm) \ +#define module_param_call(name, _set, _get, arg, perm) \ static const struct kernel_param_ops __param_ops_##name = \ - { .flags = 0, (void *)set, (void *)get }; \ + { .flags = 0, .set = _set, .get = _get }; \ __module_param_call(MODULE_PARAM_PREFIX, \ name, &__param_ops_##name, arg, perm, -1, 0) |
