diff options
| author | Stefan Agner <stefan@agner.ch> | 2015-03-05 15:09:29 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-03-05 22:23:33 -0500 |
| commit | e9647d1e74a9778539ad3232e58833210c1935f5 (patch) | |
| tree | 7c35f7e0784650a6ff52452e229fa4d9f41d3332 | |
| parent | d941bebf5e89478f480038ea30d194537eb64311 (diff) | |
| download | op-kernel-dev-e9647d1e74a9778539ad3232e58833210c1935f5.zip op-kernel-dev-e9647d1e74a9778539ad3232e58833210c1935f5.tar.gz | |
net: fec: fix unbalanced clk disable on driver unbind
When the driver is removed (e.g. using unbind through sysfs), the
clocks get disabled twice, once on fec_enet_close and once on
fec_drv_remove. Since the clocks are enabled only once, this leads
to a warning:
WARNING: CPU: 0 PID: 402 at drivers/clk/clk.c:992 clk_core_disable+0x64/0x68()
Remove the call to fec_enet_clk_enable in fec_drv_remove to balance
the clock enable/disable calls again. This has been introduce by
e8fcfcd5684a ("net: fec: optimize the clock management to save power").
Signed-off-by: Stefan Agner <stefan@agner.ch>
Acked-by: Fugang Duan <B38611@freescale.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/freescale/fec_main.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 5ff8fee..99492b7 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -3383,7 +3383,6 @@ fec_drv_remove(struct platform_device *pdev) regulator_disable(fep->reg_phy); if (fep->ptp_clock) ptp_clock_unregister(fep->ptp_clock); - fec_enet_clk_enable(ndev, false); of_node_put(fep->phy_node); free_netdev(ndev); |
