diff options
| author | Julia Lawall <Julia.Lawall@lip6.fr> | 2014-11-20 18:33:59 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-11-25 17:06:39 -0800 |
| commit | ddcbad929510bcad640693fe3cf299632823f61c (patch) | |
| tree | b76348557a01b4867f2d3937319aebccef24e820 | |
| parent | f0c1e460452138df03cb7a7f0e7546b74950b783 (diff) | |
| download | op-kernel-dev-ddcbad929510bcad640693fe3cf299632823f61c.zip op-kernel-dev-ddcbad929510bcad640693fe3cf299632823f61c.tar.gz | |
serial: icom: fix error return code
Return a negative error code on failure.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/tty/serial/icom.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/tty/serial/icom.c b/drivers/tty/serial/icom.c index d4620fe..45fc323 100644 --- a/drivers/tty/serial/icom.c +++ b/drivers/tty/serial/icom.c @@ -1550,8 +1550,10 @@ static int icom_probe(struct pci_dev *dev, icom_adapter->base_addr = pci_ioremap_bar(dev, 0); - if (!icom_adapter->base_addr) + if (!icom_adapter->base_addr) { + retval = -ENOMEM; goto probe_exit1; + } /* save off irq and request irq line */ if ( (retval = request_irq(dev->irq, icom_interrupt, |
