summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLucas Stach <l.stach@pengutronix.de>2014-05-13 14:58:21 +0200
committerTomi Valkeinen <tomi.valkeinen@ti.com>2014-05-15 13:47:11 +0300
commitdc42715fafed88f44e01eadb965fafa3ceea72bc (patch)
tree5bf4da251aabdd7e61450a7db4f49b1b44789e00
parent34bdb666f4b225471f1b57f8c5313feda8ff3c92 (diff)
downloadop-kernel-dev-dc42715fafed88f44e01eadb965fafa3ceea72bc.zip
op-kernel-dev-dc42715fafed88f44e01eadb965fafa3ceea72bc.tar.gz
video: of: display_timing: remove two unsafe error messages
The error message would try to dereference the pointer that just has been tested to be NULL. As those messages don't really add any value without the info that the np could provide, just remove them. Signed-off-by: Lucas Stach <l.stach@pengutronix.de> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
-rw-r--r--drivers/video/of_display_timing.c8
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/video/of_display_timing.c b/drivers/video/of_display_timing.c
index ba5b40f..3dc93cf 100644
--- a/drivers/video/of_display_timing.c
+++ b/drivers/video/of_display_timing.c
@@ -115,10 +115,8 @@ int of_get_display_timing(struct device_node *np, const char *name,
{
struct device_node *timing_np;
- if (!np) {
- pr_err("%s: no devicenode given\n", of_node_full_name(np));
+ if (!np)
return -EINVAL;
- }
timing_np = of_get_child_by_name(np, name);
if (!timing_np) {
@@ -142,10 +140,8 @@ struct display_timings *of_get_display_timings(struct device_node *np)
struct device_node *native_mode;
struct display_timings *disp;
- if (!np) {
- pr_err("%s: no device node given\n", of_node_full_name(np));
+ if (!np)
return NULL;
- }
timings_np = of_get_child_by_name(np, "display-timings");
if (!timings_np) {
OpenPOWER on IntegriCloud