diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2016-01-12 12:34:36 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-01-12 11:49:20 -0500 |
| commit | db9107b4972bbcb81ee6bc12f365dbe8684b137c (patch) | |
| tree | 27d7880d4441106ab21b4c8cd782480f8f8901fb | |
| parent | 9d367eddf363553c7668ba92c3b9d187ec4f71f7 (diff) | |
| download | op-kernel-dev-db9107b4972bbcb81ee6bc12f365dbe8684b137c.zip op-kernel-dev-db9107b4972bbcb81ee6bc12f365dbe8684b137c.tar.gz | |
mdio_bus: NULL dereference on allocation error
If bus = kzalloc() fails then we end up dereferencing bus when we do
"bus->irq[i] = PHY_POLL;". The code is a little simpler if we reverse
the NULL check and return directly on failure.
Fixes: e7f4dc3536a4 ('mdio: Move allocation of interrupts into core')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/phy/mdio_bus.c | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index 0be7b3d..0cba64f 100644 --- a/drivers/net/phy/mdio_bus.c +++ b/drivers/net/phy/mdio_bus.c @@ -102,11 +102,12 @@ struct mii_bus *mdiobus_alloc_size(size_t size) alloc_size = sizeof(*bus); bus = kzalloc(alloc_size, GFP_KERNEL); - if (bus) { - bus->state = MDIOBUS_ALLOCATED; - if (size) - bus->priv = (void *)bus + aligned_size; - } + if (!bus) + return NULL; + + bus->state = MDIOBUS_ALLOCATED; + if (size) + bus->priv = (void *)bus + aligned_size; /* Initialise the interrupts to polling */ for (i = 0; i < PHY_MAX_ADDR; i++) |
