summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThomas Meyer <thomas@m3y3r.de>2011-11-29 22:08:00 +0100
committerGreg Kroah-Hartman <gregkh@suse.de>2011-12-09 16:18:20 -0800
commitd5ca9db8f1dff76ef0021ed8c22c1e8fb20b4e49 (patch)
treea89b910466179d1e39c7b9a3fc4cc22ad9fc1a54
parent87763842b7014a7c6d9e992785e4c711c0085974 (diff)
downloadop-kernel-dev-d5ca9db8f1dff76ef0021ed8c22c1e8fb20b4e49.zip
op-kernel-dev-d5ca9db8f1dff76ef0021ed8c22c1e8fb20b4e49.tar.gz
USB: wusb: Use kcalloc instead of kzalloc to allocate array
The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read. The semantic patch that makes this change is available in https://lkml.org/lkml/2011/11/25/107 Signed-off-by: Thomas Meyer <thomas@m3y3r.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/usb/wusbcore/security.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/wusbcore/security.c b/drivers/usb/wusbcore/security.c
index 371f617..fa810a8 100644
--- a/drivers/usb/wusbcore/security.c
+++ b/drivers/usb/wusbcore/security.c
@@ -354,7 +354,7 @@ int wusb_dev_4way_handshake(struct wusbhc *wusbhc, struct wusb_dev *wusb_dev,
struct wusb_keydvt_in keydvt_in;
struct wusb_keydvt_out keydvt_out;
- hs = kzalloc(3*sizeof(hs[0]), GFP_KERNEL);
+ hs = kcalloc(3, sizeof(hs[0]), GFP_KERNEL);
if (hs == NULL) {
dev_err(dev, "can't allocate handshake data\n");
goto error_kzalloc;
OpenPOWER on IntegriCloud