summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJohn W. Linville <linville@tuxdriver.com>2010-01-27 14:23:17 -0500
committerJohn W. Linville <linville@tuxdriver.com>2010-01-27 15:02:03 -0500
commitd3d5621abf6d2105700795fcbdf784b9cb46b495 (patch)
treefe85093f89b8a3005f762de35a3419a92949b9d2
parent47db3a677b533489d1a5a027282aa33f46dffa79 (diff)
downloadop-kernel-dev-d3d5621abf6d2105700795fcbdf784b9cb46b495.zip
op-kernel-dev-d3d5621abf6d2105700795fcbdf784b9cb46b495.tar.gz
libertas: add comment re: v10 firmware key handling
Comment text suggested by Dan Williams <dcbw@redhat.com> in <1263952092.4481.2.camel@localhost.localdomain>. Signed-off-by: John W. Linville <linville@tuxdriver.com>
-rw-r--r--drivers/net/wireless/libertas/assoc.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/net/wireless/libertas/assoc.c b/drivers/net/wireless/libertas/assoc.c
index 0979b07..f03d5e4 100644
--- a/drivers/net/wireless/libertas/assoc.c
+++ b/drivers/net/wireless/libertas/assoc.c
@@ -2062,6 +2062,11 @@ void lbs_association_worker(struct work_struct *work)
goto out;
}
+ /*
+ * v10 FW wants WPA keys to be set/cleared before WEP key operations,
+ * otherwise it will fail to correctly associate to WEP networks.
+ * Other firmware versions don't appear to care.
+ */
if (test_bit(ASSOC_FLAG_WPA_MCAST_KEY, &assoc_req->flags) ||
test_bit(ASSOC_FLAG_WPA_UCAST_KEY, &assoc_req->flags)) {
ret = assoc_helper_wpa_keys(priv, assoc_req);
OpenPOWER on IntegriCloud