diff options
| author | Takashi Iwai <tiwai@suse.de> | 2016-02-01 12:04:55 +0100 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2016-02-01 12:22:59 +0100 |
| commit | cc85f7a634cfaf9f0713c6aa06d08817424db37a (patch) | |
| tree | 54d8a7ae120cf8c0b455d0a5f38cb30daca52a9d | |
| parent | 2d1b5c08366acd46c35a2e9aba5d650cb5bf5c19 (diff) | |
| download | op-kernel-dev-cc85f7a634cfaf9f0713c6aa06d08817424db37a.zip op-kernel-dev-cc85f7a634cfaf9f0713c6aa06d08817424db37a.tar.gz | |
ALSA: rawmidi: Remove kernel WARNING for NULL user-space buffer check
NULL user-space buffer can be passed even in a normal path, thus it's
not good to spew a kernel warning with stack trace at each time.
Just drop snd_BUG_ON() macro usage there.
BugLink: http://lkml.kernel.org/r/CACT4Y+YfVJ3L+q0i-4vyQVyyPD7V=OMX0PWPi29x9Bo3QaBLdw@mail.gmail.com
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
| -rw-r--r-- | sound/core/rawmidi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/core/rawmidi.c b/sound/core/rawmidi.c index a775984..f75d165 100644 --- a/sound/core/rawmidi.c +++ b/sound/core/rawmidi.c @@ -1178,7 +1178,7 @@ static long snd_rawmidi_kernel_write1(struct snd_rawmidi_substream *substream, long count1, result; struct snd_rawmidi_runtime *runtime = substream->runtime; - if (snd_BUG_ON(!kernelbuf && !userbuf)) + if (!kernelbuf && !userbuf) return -EINVAL; if (snd_BUG_ON(!runtime->buffer)) return -EINVAL; |
