diff options
| author | Heiner Kallweit <hkallweit1@gmail.com> | 2018-03-11 15:00:37 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-03-12 21:00:20 -0400 |
| commit | c69851e940bcdaf202d20ca7099145d9b7ec7368 (patch) | |
| tree | 4024386a0ec1ea4ef7599d26f7071b8a43afd15b | |
| parent | 83f7e38906f19614c493ad494611e3116ed26554 (diff) | |
| download | op-kernel-dev-c69851e940bcdaf202d20ca7099145d9b7ec7368.zip op-kernel-dev-c69851e940bcdaf202d20ca7099145d9b7ec7368.tar.gz | |
net: phy: set link state to down when creating the phy_device
Currently the link state is initialized to "up" when the phy_device is
being created. This is not consistent with the phy state being
initialized to PHY_DOWN.
Usually this doen't do any harm because the link state is updated
once the PHY reaches state PHY_AN. However e.g. if a LAN port isn't
used and the PHY remains down this inconsistency remains and calls
to functions like phy_print_status() give false results.
Therefore change the initialization to link being down.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/phy/phy_device.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 478405e..b285323 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -374,7 +374,7 @@ struct phy_device *phy_device_create(struct mii_bus *bus, int addr, int phy_id, dev->duplex = -1; dev->pause = 0; dev->asym_pause = 0; - dev->link = 1; + dev->link = 0; dev->interface = PHY_INTERFACE_MODE_GMII; dev->autoneg = AUTONEG_ENABLE; |
