summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlan Cox <alan@lxorguk.ukuu.org.uk>2008-04-30 00:53:27 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2008-04-30 08:29:40 -0700
commitc0754c99a6bcfcba7e1d68b75e3f25cb367af0fa (patch)
tree0c78590e52b490cd36c7f7baa71dc72d5527f03c
parent6e4d376c664ded7cb9cc1c7d0cae67c9672e46b1 (diff)
downloadop-kernel-dev-c0754c99a6bcfcba7e1d68b75e3f25cb367af0fa.zip
op-kernel-dev-c0754c99a6bcfcba7e1d68b75e3f25cb367af0fa.tar.gz
68360serial: Note that there isn't any info->mcr locking
Noticed while auditing the code for the BKL elimination project Signed-off-by: Alan Cox <alan@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--drivers/serial/68360serial.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/serial/68360serial.c b/drivers/serial/68360serial.c
index f594636..6f54010 100644
--- a/drivers/serial/68360serial.c
+++ b/drivers/serial/68360serial.c
@@ -1282,7 +1282,7 @@ static int rs_360_tiocmset(struct tty_struct *tty, struct file *file,
if (tty->flags & (1 << TTY_IO_ERROR))
return -EIO;
-
+ /* FIXME: locking on info->mcr */
if (set & TIOCM_RTS)
info->mcr |= UART_MCR_RTS;
if (set & TIOCM_DTR)
OpenPOWER on IntegriCloud