summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKen Helias <kenhelias@firemail.de>2014-08-06 16:09:14 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2014-08-06 18:01:24 -0700
commitbc18dd335a161f9229ed3aaab88ce0706cbd9867 (patch)
treed3dd9ad2bb3f24f8df02e1faaeac3cbca0ec3ba8
parentd25d9feced6c94398979a035868f03e8e8d49ce8 (diff)
downloadop-kernel-dev-bc18dd335a161f9229ed3aaab88ce0706cbd9867.zip
op-kernel-dev-bc18dd335a161f9229ed3aaab88ce0706cbd9867.tar.gz
list: make hlist_add_after() argument names match hlist_add_after_rcu()
The argument names for hlist_add_after() are poorly chosen because they look the same as the ones for hlist_add_before() but have to be used differently. hlist_add_after_rcu() has made a better choice. Signed-off-by: Ken Helias <kenhelias@firemail.de> Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> Cc: Christoph Hellwig <hch@infradead.org> Cc: Hugh Dickins <hughd@google.com> Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--include/linux/list.h14
1 files changed, 7 insertions, 7 deletions
diff --git a/include/linux/list.h b/include/linux/list.h
index ef95941..624ec7f 100644
--- a/include/linux/list.h
+++ b/include/linux/list.h
@@ -654,15 +654,15 @@ static inline void hlist_add_before(struct hlist_node *n,
*(n->pprev) = n;
}
-static inline void hlist_add_after(struct hlist_node *n,
- struct hlist_node *next)
+static inline void hlist_add_after(struct hlist_node *prev,
+ struct hlist_node *n)
{
- next->next = n->next;
- n->next = next;
- next->pprev = &n->next;
+ n->next = prev->next;
+ prev->next = n;
+ n->pprev = &prev->next;
- if(next->next)
- next->next->pprev = &next->next;
+ if (n->next)
+ n->next->pprev = &n->next;
}
/* after that we'll appear to be on some hlist and hlist_del will work */
OpenPOWER on IntegriCloud