diff options
| author | Luis de Bethencourt <luisbg@osg.samsung.com> | 2016-08-09 22:23:36 +0100 |
|---|---|---|
| committer | Luis de Bethencourt <luisbg@osg.samsung.com> | 2016-10-08 10:01:31 +0100 |
| commit | bbe1bd0b6bba138eaf441c6c964bde9866da8808 (patch) | |
| tree | 6b4ab39d99b91607e2b1d89a52834f1eaa3cc91a | |
| parent | d1a8c70676c7e2cd4b80f494aed17b5813f2be44 (diff) | |
| download | op-kernel-dev-bbe1bd0b6bba138eaf441c6c964bde9866da8808.zip op-kernel-dev-bbe1bd0b6bba138eaf441c6c964bde9866da8808.tar.gz | |
befs: add check for ag_shift in superblock
ag_shift and blocks_per_ag contain the same information in different ways,
same as block_shift and block_size do. It is worth checking this two are
consistent, but since blocks_per_ag isn't documented as mandatory to use
some implementations of befs don't enforce this, so making it non-fatal if
they don't match and just having it as a warning.
Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Signed-off-by: Salah Triki <salah.triki@gmail.com>
| -rw-r--r-- | fs/befs/super.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/fs/befs/super.c b/fs/befs/super.c index dc13df8..c36745d 100644 --- a/fs/befs/super.c +++ b/fs/befs/super.c @@ -103,6 +103,13 @@ befs_check_sb(struct super_block *sb) return BEFS_ERR; } + + /* ag_shift also encodes the same information as blocks_per_ag in a + * different way, non-fatal consistency check + */ + if ((1 << befs_sb->ag_shift) != befs_sb->blocks_per_ag) + befs_error(sb, "ag_shift disagrees with blocks_per_ag."); + if (befs_sb->log_start != befs_sb->log_end || befs_sb->flags == BEFS_DIRTY) { befs_error(sb, "Filesystem not clean! There are blocks in the " "journal. You must boot into BeOS and mount this volume " |
