diff options
| author | Haojian Zhuang <haojian.zhuang@gmail.com> | 2012-12-03 16:14:37 +0800 |
|---|---|---|
| committer | Mike Turquette <mturquette@linaro.org> | 2013-01-11 18:43:27 -0800 |
| commit | bab53301c3846ae9a5e1142dca2976f434f70481 (patch) | |
| tree | 2d872a2a8fc40d6f4975ee153f8d76f227d7813a | |
| parent | 4895084c87ab0973308021d755596798160b682a (diff) | |
| download | op-kernel-dev-bab53301c3846ae9a5e1142dca2976f434f70481.zip op-kernel-dev-bab53301c3846ae9a5e1142dca2976f434f70481.tar.gz | |
clk: fixed-factor: round_rate should use do_div
clk->rate = parent->rate / div * mult
The formula is OK. But it may overflow while we do operate with
unsigned long. So use do_div instead.
Signed-off-by: Haojian Zhuang <haojian.zhuang@gmail.com>
Signed-off-by: Mike Turquette <mturquette@linaro.org>
[mturquette@linaro.org: improved $SUBJECT]
| -rw-r--r-- | drivers/clk/clk-fixed-factor.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/clk/clk-fixed-factor.c b/drivers/clk/clk-fixed-factor.c index a489985..1ef271e 100644 --- a/drivers/clk/clk-fixed-factor.c +++ b/drivers/clk/clk-fixed-factor.c @@ -28,8 +28,11 @@ static unsigned long clk_factor_recalc_rate(struct clk_hw *hw, unsigned long parent_rate) { struct clk_fixed_factor *fix = to_clk_fixed_factor(hw); + unsigned long long int rate; - return parent_rate * fix->mult / fix->div; + rate = (unsigned long long int)parent_rate * fix->mult; + do_div(rate, fix->div); + return (unsigned long)rate; } static long clk_factor_round_rate(struct clk_hw *hw, unsigned long rate, |
