summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJohan Hovold <johan@kernel.org>2017-03-16 11:39:29 -0700
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2017-03-16 13:56:52 -0700
commitba340d7b83703768ce566f53f857543359aa1b98 (patch)
treedb3c84d288b2bbc111fcf4ccaba5d3aa79591dc5
parent5cc4a1a9f5c179795c8a1f2b0f4361829d6a070e (diff)
downloadop-kernel-dev-ba340d7b83703768ce566f53f857543359aa1b98.zip
op-kernel-dev-ba340d7b83703768ce566f53f857543359aa1b98.tar.gz
Input: hanwang - validate number of endpoints before using them
Make sure to check the number of endpoints to avoid dereferencing a NULL-pointer should a malicious device lack endpoints. Fixes: bba5394ad3bd ("Input: add support for Hanwang tablets") Signed-off-by: Johan Hovold <johan@kernel.org> Cc: stable@vger.kernel.org # 2.6.37 Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
-rw-r--r--drivers/input/tablet/hanwang.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/input/tablet/hanwang.c b/drivers/input/tablet/hanwang.c
index cd85205..df4bea9 100644
--- a/drivers/input/tablet/hanwang.c
+++ b/drivers/input/tablet/hanwang.c
@@ -340,6 +340,9 @@ static int hanwang_probe(struct usb_interface *intf, const struct usb_device_id
int error;
int i;
+ if (intf->cur_altsetting->desc.bNumEndpoints < 1)
+ return -ENODEV;
+
hanwang = kzalloc(sizeof(struct hanwang), GFP_KERNEL);
input_dev = input_allocate_device();
if (!hanwang || !input_dev) {
OpenPOWER on IntegriCloud