diff options
author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2018-05-02 10:23:59 +0200 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2018-05-03 11:47:42 +0200 |
commit | aee1a37d0f1a904a1443c327211f4bcd645681f1 (patch) | |
tree | 73da69c1a410fe2fd26be943eaeaaa27b75c231c | |
parent | 190c462d5be19ba622a82f5fd0625087c870a1e6 (diff) | |
download | op-kernel-dev-aee1a37d0f1a904a1443c327211f4bcd645681f1.zip op-kernel-dev-aee1a37d0f1a904a1443c327211f4bcd645681f1.tar.gz |
dma-fence: remove fill_driver_data callback
Noticed while I was typing docs. Entirely unused.
v2: Remove reference in @timeline_value_str too. While at it clarify
why timeline_value_str has a fence parameter - we don't have an
explicit timeline structure unfortunately.
Cc: Eric Anholt <eric@anholt.net>
Reviewed-by: Christian König <christian.koenig@amd.com> (v1)
Reviewed-by: Eric Anholt <eric@anholt.net>
Cc: Christian König <christian.koenig@amd.com> (v1)
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20180502082359.30345-1-daniel.vetter@ffwll.ch
-rw-r--r-- | include/linux/dma-fence.h | 16 |
1 files changed, 3 insertions, 13 deletions
diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h index eb9b05a..111aefe 100644 --- a/include/linux/dma-fence.h +++ b/include/linux/dma-fence.h @@ -218,17 +218,6 @@ struct dma_fence_ops { void (*release)(struct dma_fence *fence); /** - * @fill_driver_data: - * - * Callback to fill in free-form debug info. - * - * Returns amount of bytes filled, or negative error on failure. - * - * This callback is optional. - */ - int (*fill_driver_data)(struct dma_fence *fence, void *data, int size); - - /** * @fence_value_str: * * Callback to fill in free-form debug info specific to this fence, like @@ -242,8 +231,9 @@ struct dma_fence_ops { * @timeline_value_str: * * Fills in the current value of the timeline as a string, like the - * sequence number. This should match what @fill_driver_data prints for - * the most recently signalled fence (assuming no delayed signalling). + * sequence number. Note that the specific fence passed to this function + * should not matter, drivers should only use it to look up the + * corresponding timeline structures. */ void (*timeline_value_str)(struct dma_fence *fence, char *str, int size); |