summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichal Privoznik <mprivozn@redhat.com>2014-12-14 13:36:52 +0100
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2014-12-19 23:01:03 +0100
commitad1d8313cdeec8bc10cecb2143d047eb565b9f65 (patch)
tree456df70b2c1e6d0df4c94c2e199575b6d687bff5
parent2a813f1aaaf00a7eb65bef8da2fe9fcec0aabaaa (diff)
downloadop-kernel-dev-ad1d8313cdeec8bc10cecb2143d047eb565b9f65.zip
op-kernel-dev-ad1d8313cdeec8bc10cecb2143d047eb565b9f65.tar.gz
tools / cpupower: Correctly detect if running as root
Some operations, like frequency-set, need root privileges. However, the way that this is detected is not correct. The getuid() is called, while in fact geteuid() should be. This way we can allow distributions or users to set SETUID flags on the cpupower binary if they want to and let regular users change the cpu frequency governor. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> Acked-by: Thomas Renninger <trenn@suse.de> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
-rw-r--r--tools/power/cpupower/utils/cpupower.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/power/cpupower/utils/cpupower.c b/tools/power/cpupower/utils/cpupower.c
index 7cdcf88..9ea9143 100644
--- a/tools/power/cpupower/utils/cpupower.c
+++ b/tools/power/cpupower/utils/cpupower.c
@@ -199,7 +199,7 @@ int main(int argc, const char *argv[])
}
get_cpu_info(0, &cpupower_cpu_info);
- run_as_root = !getuid();
+ run_as_root = !geteuid();
if (run_as_root) {
ret = uname(&uts);
if (!ret && !strcmp(uts.machine, "x86_64") &&
OpenPOWER on IntegriCloud