diff options
| author | Roy.Li <rongqing.li@windriver.com> | 2011-09-26 09:08:00 +0800 |
|---|---|---|
| committer | Ralf Baechle <ralf@linux-mips.org> | 2011-09-27 17:33:06 +0200 |
| commit | a4be637b34a543af5b5421a8ee0ee04d30f5f58e (patch) | |
| tree | acaf6c4a5395be2ccb8e9e9429109bf9e7cc9827 | |
| parent | 2f19d080fb14bdddf11bf54d4db6306235c46c99 (diff) | |
| download | op-kernel-dev-a4be637b34a543af5b5421a8ee0ee04d30f5f58e.zip op-kernel-dev-a4be637b34a543af5b5421a8ee0ee04d30f5f58e.tar.gz | |
staging/octeon: Software should check the checksum of no tcp/udp packets
Icmp packets with wrong checksum are never dropped since skb->ip_summed is
set to CHECKSUM_UNNECESSARY.
When icmp packets with wrong checksum pass through the octeon net driver,
the not_IP, IP_exc, L4_error hardware indicators show no error. so the
driver sets CHECKSUM_UNNECESSARY on skb->ip_summed.
L4_error only works for TCP/UDP, not for ICMP.
Signed-off-by: Roy.Li <rongqing.li@windriver.com>
To: linux-mips@linux-mips.org
Cc: netdev@vger.kernel.org
Cc: ralf@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/2798/
Acked-by: David Daney <david.daney@cavium.com>
Cc: Greg KH <greg@kroah.com
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
| -rw-r--r-- | drivers/staging/octeon/ethernet-rx.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c index 1a7c19a..8b307b4 100644 --- a/drivers/staging/octeon/ethernet-rx.c +++ b/drivers/staging/octeon/ethernet-rx.c @@ -411,7 +411,8 @@ static int cvm_oct_napi_poll(struct napi_struct *napi, int budget) skb->protocol = eth_type_trans(skb, dev); skb->dev = dev; - if (unlikely(work->word2.s.not_IP || work->word2.s.IP_exc || work->word2.s.L4_error)) + if (unlikely(work->word2.s.not_IP || work->word2.s.IP_exc || + work->word2.s.L4_error || !work->word2.s.tcp_or_udp)) skb->ip_summed = CHECKSUM_NONE; else skb->ip_summed = CHECKSUM_UNNECESSARY; |
