summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRickard Strandqvist <rickard_strandqvist@spectrumdigital.se>2014-06-28 23:34:38 +0200
committerLee Jones <lee.jones@linaro.org>2014-07-09 14:58:22 +0100
commita3dd01e17756e85badd587de774cec783abe1b19 (patch)
tree6f288648fb44c55b3a4af5b47f62f20142956b96
parent005d16b6022676ba8c6ae93e2d38cb0e70e0ef92 (diff)
downloadop-kernel-dev-a3dd01e17756e85badd587de774cec783abe1b19.zip
op-kernel-dev-a3dd01e17756e85badd587de774cec783abe1b19.tar.gz
mfd: ab8500-debugfs: Cleaning up unnecessary to test, unsigned can't be negative.
Unsigned variable can't be negative so it is unnecessary to test it This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Signed-off-by: Lee Jones <lee.jones@linaro.org>
-rw-r--r--drivers/mfd/ab8500-debugfs.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c
index 8452c15..e23fcba 100644
--- a/drivers/mfd/ab8500-debugfs.c
+++ b/drivers/mfd/ab8500-debugfs.c
@@ -2503,7 +2503,7 @@ static ssize_t ab8500_gpadc_trig_timer_write(struct file *file,
if (err)
return err;
- if ((user_trig_timer >= 0) && (user_trig_timer <= 255)) {
+ if (user_trig_timer <= 255) {
trig_timer = (u8) user_trig_timer;
} else {
dev_err(dev, "debugfs error input: "
OpenPOWER on IntegriCloud