diff options
| author | Rajat Jain <rajatja@google.com> | 2017-01-02 22:34:15 -0800 |
|---|---|---|
| committer | Bjorn Helgaas <bhelgaas@google.com> | 2017-02-14 17:44:47 -0600 |
| commit | a142f4d3e5c54db5e942fa6ee5f3dc0e8c83207b (patch) | |
| tree | 385711c7d5c2f38a9095f2d04632cdbfabf6175d | |
| parent | aeda9adebab8b5bdd90576e3065a1f3f948279ad (diff) | |
| download | op-kernel-dev-a142f4d3e5c54db5e942fa6ee5f3dc0e8c83207b.zip op-kernel-dev-a142f4d3e5c54db5e942fa6ee5f3dc0e8c83207b.tar.gz | |
PCI/ASPM: Add comment about L1 substate latency
Since the exit latencies for L1 substates are not advertised by a device,
it is not clear in spec how to do a L1 substate exit latency check. We
assume that the L1 exit latencies advertised by a device include L1
substate latencies (and hence do not do any check). If that is not true,
we should do some sort of check here.
(I'm not clear about what that check should like currently. I'd be glad to
take up any suggestions).
Signed-off-by: Rajat Jain <rajatja@google.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
| -rw-r--r-- | drivers/pci/pcie/aspm.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c index ceb2395..a9bcd56 100644 --- a/drivers/pci/pcie/aspm.c +++ b/drivers/pci/pcie/aspm.c @@ -403,6 +403,14 @@ static void pcie_aspm_check_latency(struct pci_dev *endpoint) * Check L1 latency. * Every switch on the path to root complex need 1 * more microsecond for L1. Spec doesn't mention L0s. + * + * The exit latencies for L1 substates are not advertised + * by a device. Since the spec also doesn't mention a way + * to determine max latencies introduced by enabling L1 + * substates on the components, it is not clear how to do + * a L1 substate exit latency check. We assume that the + * L1 exit latencies advertised by a device include L1 + * substate latencies (and hence do not do any check). */ latency = max_t(u32, link->latency_up.l1, link->latency_dw.l1); if ((link->aspm_capable & ASPM_STATE_L1) && |
