diff options
| author | Paul E. McKenney <paulmck@linux.vnet.ibm.com> | 2011-02-10 11:57:27 +0000 |
|---|---|---|
| committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2011-03-02 16:50:25 +1100 |
| commit | 9ff0c61d08ac4defa5ad6c65935a67643b8f4ce3 (patch) | |
| tree | d37475a6aa440c0e2a37af9700818ed7fa0a3c64 | |
| parent | 31116f0b7e8965ff3c2fd09ab240b7746d5556b3 (diff) | |
| download | op-kernel-dev-9ff0c61d08ac4defa5ad6c65935a67643b8f4ce3.zip op-kernel-dev-9ff0c61d08ac4defa5ad6c65935a67643b8f4ce3.tar.gz | |
powerpc: Mask smp_processor_id() false positive
The rtas_event_scan() function uses smp_processor_id() to select a
starting point in cpu_online_mask, and does so under the protection
of get_online_cpus(). This might not select the current processor
in any case, so switch to raw_smp_processor_id().
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
| -rw-r--r-- | arch/powerpc/kernel/rtasd.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/arch/powerpc/kernel/rtasd.c b/arch/powerpc/kernel/rtasd.c index 049dbec..7980ec0 100644 --- a/arch/powerpc/kernel/rtasd.c +++ b/arch/powerpc/kernel/rtasd.c @@ -412,7 +412,8 @@ static void rtas_event_scan(struct work_struct *w) get_online_cpus(); - cpu = cpumask_next(smp_processor_id(), cpu_online_mask); + /* raw_ OK because just using CPU as starting point. */ + cpu = cpumask_next(raw_smp_processor_id(), cpu_online_mask); if (cpu >= nr_cpu_ids) { cpu = cpumask_first(cpu_online_mask); |
