summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTakashi Iwai <tiwai@suse.de>2012-01-09 18:22:35 +0100
committerTakashi Iwai <tiwai@suse.de>2012-01-09 18:27:44 +0100
commit9badda0a0afffebbe1cb30565800896534a6c5bd (patch)
tree2b004e66d252420b68ce68f86c07444576c6dc7b
parent80c8a2a372599e604b04a9c568952fe39cd1851d (diff)
downloadop-kernel-dev-9badda0a0afffebbe1cb30565800896534a6c5bd.zip
op-kernel-dev-9badda0a0afffebbe1cb30565800896534a6c5bd.tar.gz
ALSA: hdsp - Fix potential Oops in snd_hdsp_info_pref_sync_ref()
Dan Carpenter reported that setting 0 to uinfo->value.enumerated.items in snd_hdsp_info_pref_sync_ref() may lead to Oops. This function should return an error immediately in such a case instead. Cc: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r--sound/pci/rme9652/hdsp.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/sound/pci/rme9652/hdsp.c b/sound/pci/rme9652/hdsp.c
index 0111203..b68cdec 100644
--- a/sound/pci/rme9652/hdsp.c
+++ b/sound/pci/rme9652/hdsp.c
@@ -2640,8 +2640,7 @@ static int snd_hdsp_info_pref_sync_ref(struct snd_kcontrol *kcontrol, struct snd
uinfo->value.enumerated.items = 3;
break;
default:
- uinfo->value.enumerated.items = 0;
- break;
+ return -EINVAL;
}
if (uinfo->value.enumerated.item >= uinfo->value.enumerated.items)
OpenPOWER on IntegriCloud