summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCorey Minyard <cminyard@mvista.com>2014-11-07 07:57:31 -0600
committerCorey Minyard <cminyard@mvista.com>2014-12-11 15:04:11 -0600
commit99ab32f3b5d705be562b8c4d9dca7c1ae3dc2cdf (patch)
tree3577b74fa4a0f45cb9db83bfb0a02eb1d12e5349
parentb874b985c816c74a9bda04082f18db88dcbc808a (diff)
downloadop-kernel-dev-99ab32f3b5d705be562b8c4d9dca7c1ae3dc2cdf.zip
op-kernel-dev-99ab32f3b5d705be562b8c4d9dca7c1ae3dc2cdf.tar.gz
ipmi: Remove the now unused priority from SMI sender
Since the queue was moved into the message handler, the priority field is now irrelevant. Signed-off-by: Corey Minyard <cminyard@mvista.com>
-rw-r--r--drivers/char/ipmi/ipmi_msghandler.c4
-rw-r--r--drivers/char/ipmi/ipmi_si_intf.c3
-rw-r--r--include/linux/ipmi_smi.h9
3 files changed, 7 insertions, 9 deletions
diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
index b705218..5fa83f7 100644
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -1516,7 +1516,7 @@ static void smi_send(ipmi_smi_t intf, struct ipmi_smi_handlers *handlers,
spin_unlock_irqrestore(&intf->xmit_msgs_lock, flags);
if (smi_msg)
- handlers->sender(intf->send_info, smi_msg, 0);
+ handlers->sender(intf->send_info, smi_msg);
}
/*
@@ -3908,7 +3908,7 @@ static void smi_recv_tasklet(unsigned long val)
if (!run_to_completion)
spin_unlock_irqrestore(&intf->xmit_msgs_lock, flags);
if (newmsg)
- intf->handlers->sender(intf->send_info, newmsg, 0);
+ intf->handlers->sender(intf->send_info, newmsg);
handle_new_recv_msgs(intf);
}
diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index d31a7fc..4f11301 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -892,8 +892,7 @@ static void check_start_timer_thread(struct smi_info *smi_info)
}
static void sender(void *send_info,
- struct ipmi_smi_msg *msg,
- int priority)
+ struct ipmi_smi_msg *msg)
{
struct smi_info *smi_info = send_info;
enum si_sm_result result;
diff --git a/include/linux/ipmi_smi.h b/include/linux/ipmi_smi.h
index 6131845..0b1e569 100644
--- a/include/linux/ipmi_smi.h
+++ b/include/linux/ipmi_smi.h
@@ -98,12 +98,11 @@ struct ipmi_smi_handlers {
operation is not allowed to fail. If an error occurs, it
should report back the error in a received message. It may
do this in the current call context, since no write locks
- are held when this is run. If the priority is > 0, the
- message will go into a high-priority queue and be sent
- first. Otherwise, it goes into a normal-priority queue. */
+ are held when this is run. Message are delivered one at
+ a time by the message handler, a new message will not be
+ delivered until the previous message is returned. */
void (*sender)(void *send_info,
- struct ipmi_smi_msg *msg,
- int priority);
+ struct ipmi_smi_msg *msg);
/* Called by the upper layer to request that we try to get
events from the BMC we are attached to. */
OpenPOWER on IntegriCloud