summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJesper Juhl <jj@chaosbits.net>2012-03-07 19:09:34 +0000
committerAlasdair G Kergon <agk@redhat.com>2012-03-07 19:09:34 +0000
commit902c6a96a7cb9c50d2a8aed1788efad0a5d8f04c (patch)
tree4f6f797bbaf2d5708d3e01269c1019bd9fb205b5
parent192cfd58774b4d17b2fe8bdc77d89c2ef4e0591d (diff)
downloadop-kernel-dev-902c6a96a7cb9c50d2a8aed1788efad0a5d8f04c.zip
op-kernel-dev-902c6a96a7cb9c50d2a8aed1788efad0a5d8f04c.tar.gz
dm ioctl: do not leak argv if target message only contains whitespace
If 'argc' is zero we jump to the 'out:' label, but this leaks the (unused) memory that 'dm_split_args()' allocated for 'argv' if the string being split consisted entirely of whitespace. Jump to the 'out_argv:' label instead to free up that memory. Signed-off-by: Jesper Juhl <jj@chaosbits.net> Cc: stable@kernel.org Signed-off-by: Alasdair G Kergon <agk@redhat.com>
-rw-r--r--drivers/md/dm-ioctl.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c
index 31c2dc2..1ce84ed 100644
--- a/drivers/md/dm-ioctl.c
+++ b/drivers/md/dm-ioctl.c
@@ -1437,7 +1437,7 @@ static int target_message(struct dm_ioctl *param, size_t param_size)
if (!argc) {
DMWARN("Empty message received.");
- goto out;
+ goto out_argv;
}
table = dm_get_live_table(md);
OpenPOWER on IntegriCloud