diff options
| author | Richard Alpe <richard.alpe@ericsson.com> | 2015-08-17 14:15:10 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-08-17 10:39:54 -0700 |
| commit | 8f8ff9135b28a7560a5627aceaf289e3f0d4cd64 (patch) | |
| tree | 8b772622f82142d1e4950d9985a8180580d0cdeb | |
| parent | da3cc2da7c08dc1f4371a4cc2eb83b22a0cf83a8 (diff) | |
| download | op-kernel-dev-8f8ff9135b28a7560a5627aceaf289e3f0d4cd64.zip op-kernel-dev-8f8ff9135b28a7560a5627aceaf289e3f0d4cd64.tar.gz | |
tipc: don't sanity check non-existing TLV (NL compat)
A zero length payload means that no TLV (Type Length Value) data has
been passed. Prior to this patch a non-existing TLV could be sanity
checked with TLV_OK() resulting in random behavior where a user
sending an empty message occasionally got a incorrect "operation not
supported" message back.
Signed-off-by: Richard Alpe <richard.alpe@ericsson.com>
Reviewed-by: Erik Hugne <erik.hugne@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/tipc/netlink_compat.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c index 53e0fee..1eadc95 100644 --- a/net/tipc/netlink_compat.c +++ b/net/tipc/netlink_compat.c @@ -1114,7 +1114,7 @@ static int tipc_nl_compat_recv(struct sk_buff *skb, struct genl_info *info) } len = nlmsg_attrlen(req_nlh, GENL_HDRLEN + TIPC_GENL_HDRLEN); - if (TLV_GET_LEN(msg.req) && !TLV_OK(msg.req, len)) { + if (len && !TLV_OK(msg.req, len)) { msg.rep = tipc_get_err_tlv(TIPC_CFG_NOT_SUPPORTED); err = -EOPNOTSUPP; goto send; |
