summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAl Viro <viro@zeniv.linux.org.uk>2017-04-13 03:10:18 -0400
committerAl Viro <viro@zeniv.linux.org.uk>2017-04-17 14:23:20 -0400
commit890559e34eac1fb90a4b5916d4a1387376a05d51 (patch)
treebc13690fd3d6c481a05ca416a92710b0816f64ec
parent4f7d029b9bf009fbee76bb10c0c4351a1870d2f3 (diff)
downloadop-kernel-dev-890559e34eac1fb90a4b5916d4a1387376a05d51.zip
op-kernel-dev-890559e34eac1fb90a4b5916d4a1387376a05d51.tar.gz
orangefs_bufmap_copy_from_iovec(): fix EFAULT handling
short copy here should mean instant EFAULT, not "move to the next page and hope it fails there, this time with nothing copied" Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
-rw-r--r--fs/orangefs/orangefs-bufmap.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/fs/orangefs/orangefs-bufmap.c b/fs/orangefs/orangefs-bufmap.c
index 6333cbb..83b5060 100644
--- a/fs/orangefs/orangefs-bufmap.c
+++ b/fs/orangefs/orangefs-bufmap.c
@@ -521,13 +521,11 @@ int orangefs_bufmap_copy_from_iovec(struct iov_iter *iter,
size_t n = size;
if (n > PAGE_SIZE)
n = PAGE_SIZE;
- n = copy_page_from_iter(page, 0, n, iter);
- if (!n)
+ if (copy_page_from_iter(page, 0, n, iter) != n)
return -EFAULT;
size -= n;
}
return 0;
-
}
/*
OpenPOWER on IntegriCloud