diff options
| author | Paul E. McKenney <paulmck@linux.vnet.ibm.com> | 2012-10-15 21:35:59 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-10-16 18:17:44 -0700 |
| commit | 85eae82a0855d49852b87deac8653e4ebc8b291f (patch) | |
| tree | c7b6a9334bf9f56c361537c8273a12f4b0549e0b | |
| parent | 75fa29c7000924060677e0591368045576daad93 (diff) | |
| download | op-kernel-dev-85eae82a0855d49852b87deac8653e4ebc8b291f.zip op-kernel-dev-85eae82a0855d49852b87deac8653e4ebc8b291f.tar.gz | |
printk: Fix scheduling-while-atomic problem in console_cpu_notify()
The console_cpu_notify() function runs with interrupts disabled in the
CPU_DYING case. It therefore cannot block, for example, as will happen
when it calls console_lock(). Therefore, remove the CPU_DYING leg of
the switch statement to avoid this problem.
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | kernel/printk.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/kernel/printk.c b/kernel/printk.c index 66a2ea3..2d607f4 100644 --- a/kernel/printk.c +++ b/kernel/printk.c @@ -1890,7 +1890,6 @@ static int __cpuinit console_cpu_notify(struct notifier_block *self, switch (action) { case CPU_ONLINE: case CPU_DEAD: - case CPU_DYING: case CPU_DOWN_FAILED: case CPU_UP_CANCELED: console_lock(); |
