summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJames Bottomley <James.Bottomley@SteelEye.com>2007-05-09 02:33:29 -0700
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2007-05-09 12:30:49 -0700
commit809aa5048fb7e7fd3bf0aa1fb169c42db0f63b08 (patch)
tree11b46cfe54de960d7c5ea83c2ee31ee8222ad8b3
parent818563dceccf695a71f8bd683a249e7bb09e3240 (diff)
downloadop-kernel-dev-809aa5048fb7e7fd3bf0aa1fb169c42db0f63b08.zip
op-kernel-dev-809aa5048fb7e7fd3bf0aa1fb169c42db0f63b08.tar.gz
mca: fix bus matching
There's a bug in the MCA bus matching algorithm in that it promotes from signed short to int before comparing with the actual id and does sign extension on anything > 0x7fff (which means that pos ids > 0x7fff never get correctly matched). Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--drivers/mca/mca-bus.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mca/mca-bus.c b/drivers/mca/mca-bus.c
index da862e4..a70fe00 100644
--- a/drivers/mca/mca-bus.c
+++ b/drivers/mca/mca-bus.c
@@ -47,7 +47,7 @@ static int mca_bus_match (struct device *dev, struct device_driver *drv)
{
struct mca_device *mca_dev = to_mca_device (dev);
struct mca_driver *mca_drv = to_mca_driver (drv);
- const short *mca_ids = mca_drv->id_table;
+ const unsigned short *mca_ids = mca_drv->id_table;
int i;
if (!mca_ids)
OpenPOWER on IntegriCloud